[PATCH] D75866: [AIX] supporting the visibility attribute for aix assembly

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:802
+void MCAsmStreamer::emitXCOFFSymbolLinkageWithVisibility(
+    MCSymbol *Symbol, MCSymbolAttr Linkage, MCSymbolAttr Visibility) {
+
----------------
DiggerLin wrote:
> jasonliu wrote:
> > Could we add `const` for the `Symbol` argument?
> sorry , I can not add const in this patch, for  in the function 
> MCXCOFFStreamer::emitXCOFFSymbolLinkageWithVisibility()
> 
> the function calls the 
> bool MCXCOFFStreamer::emitSymbolAttribute(MCSymbol *Sym,Symbol, Visibility)
> 
> . if we want to change to " const  MCSymbol *Sym" , we can add a NFC patch later.
You are right. I didn't realize it needs to be non-const for MCXCOFFStreamer version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75866/new/

https://reviews.llvm.org/D75866