[PATCH] D80787: [VPlan] Support extracting lanes for defs managed in VPTransformState.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:281
+    if (Data.PerPartOutput.count(Def)) {
+      auto *VecPart = Data.PerPartOutput[Def][Instance.Part];
+      // TODO: Cache created scalar values.
----------------
Ayal wrote:
> This should in general also support **scalar** Values set per part, i.e., invariants.
> Going forward, better model extracts and inserts upfront in VPlan, rather than generating them on-demand during code-gen.
> Going forward, better model extracts and inserts upfront in VPlan, rather than generating them on-demand during code-gen.

Sounds good! I'll land the patch as-is tomorrow as a first step, unless there's additional feedback.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80787/new/

https://reviews.llvm.org/D80787