[PATCH] D81026: Inline Cost improvement - GetElementPtr with constant operands

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 2 13:10:37 PDT 2020


mtrofin added a comment.

What is the impact on the performance of the generated code?

Also, consider offering an opt-in flag.



================
Comment at: llvm/lib/Analysis/InlineCost.cpp:1008
+      SmallVector<Constant *, 2> Indices;
+      for (unsigned int index = 1 ; index < COps.size() ; ++index)
+        Indices.push_back(COps[index]);
----------------
Code style: Index (not index)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81026/new/

https://reviews.llvm.org/D81026





More information about the llvm-commits mailing list