[PATCH] D80787: [VPlan] Support extracting lanes for defs managed in VPTransformState.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Thanks for this. I have played quite a bit with this patch (in the context of D79100 <https://reviews.llvm.org/D79100>), and this behaves entirely as expected. The change is minimal/straightforward, so LGTM.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:278
+    // defs are managed by VPTransformState. Other Defs are still created by ILV
+    // and managed in its ValueMap. For those this method currently just
+    // delegates the call to ILV below.
----------------
Really minor nit: perhaps "For those" -> "For those Defs" 
(think that reads a bit easier)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80787/new/

https://reviews.llvm.org/D80787