[PATCH] D79940: [mlir] Rename conversions involving ex-Loop dialect to mention SCF

Tue Jun 2 04:24:59 PDT 2020

ftynse marked 2 inline comments as done.
ftynse added a comment.
Herald added a project: MLIR.

eb8edd852601270eff090dc7d42acde7cd7a2573 <https://reviews.llvm.org/rGeb8edd852601270eff090dc7d42acde7cd7a2573>

================
Comment at: mlir/include/mlir/Conversion/SCFToGPU/SCFToGPUPass.h:8
 //===----------------------------------------------------------------------===//
 #ifndef MLIR_CONVERSION_LOOPSTOGPU_LOOPSTOGPUPASS_H_
 #define MLIR_CONVERSION_LOOPSTOGPU_LOOPSTOGPUPASS_H_
----------------
rriddle wrote:
> Looks like this was missed.
Good catch, thanks!

================
Comment at: mlir/lib/Conversion/SCFToGPU/SCFToGPUPass.cpp:22
+#define PASS_NAME "convert-scf-to-gpu"
 #define LOOPOP_TO_GPU_PASS_NAME "convert-loop-op-to-gpu"

----------------
rriddle wrote:
> Should this be renamed/removed?
Looks unused, so let's remove.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79940/new/

https://reviews.llvm.org/D79940