[PATCH] D80924: [CostModel] Use MaybeAlign in getMemoryOpCost

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 2 01:38:44 PDT 2020


gchatelet added a comment.

Why is it superior to use `MaybeAlign` instead of `Align`?
`MaybeAlign` forces the user to consider the `None` case, this is more logic to consider.
I fail to see why loosening the interface is desirable. Did I miss something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80924/new/

https://reviews.llvm.org/D80924





More information about the llvm-commits mailing list