[PATCH] D80838: [llvm-ar] Add more tests for errors in opening archives

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

In D80838#2065845 <https://reviews.llvm.org/D80838#2065845>, @jhenderson wrote:

> The test you have modified is for testing the "p" (print) operation, but your new test cases are not really about that option, but rather about generic file handling. I'm not convinced they belong in this test file, but @gbreynoo might have other opinions, since he's the one who's been working on the llvm-ar testing recently.


We put them in this file because the "Archive does not exist" test was there, but yup, it'd make sense to move them out.

> Could you clarify why you are adding these test cases? I don't think the behaviour is really part of llvm-ar, but rather part of the underlying support libraries which control when a file can be opened or not.

The logic to handle these errors is in llvm-ar.cpp (specifically one of the errors that's being modified in D80846 <https://reviews.llvm.org/D80846>), and it didn't have any test coverage before this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80838/new/

https://reviews.llvm.org/D80838