[PATCH] D80406: [LLD][ThinLTO] A switch to allow compilation of only one module.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/LTO.cpp:142
 
+  for (auto &name : config->thinLTOModulesToCompile)
+    c.ThinLTOModulesToCompile.emplace_back(name);
----------------
`const std::string &`  - Don't use auto unless it is obvious.



================
Comment at: lld/ELF/LTO.cpp:143
+  for (auto &name : config->thinLTOModulesToCompile)
+    c.ThinLTOModulesToCompile.emplace_back(name);
+
----------------
`push_back`. `emplace_back` makes people wonder whether you use a smart constructor


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80406/new/

https://reviews.llvm.org/D80406