[PATCH] D80960: Support other llc-like tools in update_llc_test_checks.py

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 15:43:34 PDT 2020


bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

Seems straightforward enough. A couple of minor nitpicks.



================
Comment at: llvm/utils/update_llc_test_checks.py:23
 ADVERT = ' NOTE: Assertions have been autogenerated by '
-
+LLC_LIKE_TOOLS = ('llc',) 
 
----------------
A comment explaining why this is a tuple of one (much like the commit message) would be helpful here.


================
Comment at: llvm/utils/update_llc_test_checks.py:132
 
-      raw_tool_output = common.invoke_tool(args.llc_binary, llc_args, test)
+      raw_tool_output = common.invoke_tool(args.llc_binary or llc_tool, llc_args, test)
       triple = triple_in_cmd or triple_in_ir
----------------
Please stick to 80-col


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80960/new/

https://reviews.llvm.org/D80960





More information about the llvm-commits mailing list