[PATCH] D80512: [MC] Changes to help improve target specific symbol disassembly

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 11:18:54 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1440
+
+      // Only fall back to normal flow if the symbol is decoded partially
+      // (SoftFail) or when the target ignores the symbol for special treatment.
----------------
The comments should probably be moved before `if`.

You can say that most targets return `Ignore`, and state how AMDGPU and WebAssembly are different and why they do `continue`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80512/new/

https://reviews.llvm.org/D80512





More information about the llvm-commits mailing list