[PATCH] D80261: [SVE] Eliminate calls to default-false VectorType::get() from IR

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 11:18:50 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/IR/ConstantFold.cpp:884
   if (all_of(Mask, [](int Elt) { return Elt == UndefMaskElem; })) {
-    return UndefValue::get(VectorType::get(EltTy, MaskNumElts));
+    return UndefValue::get(FixedVectorType::get(EltTy, MaskNumElts));
   }
----------------
This should be MaskEltCount... we probably want a testcase for that, though.  I'll look into it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80261/new/

https://reviews.llvm.org/D80261





More information about the llvm-commits mailing list