[PATCH] D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol

Digger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 09:39:20 PDT 2020


DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5244
+    return cast<MCSymbolXCOFF>(
+        Context.getOrCreateSymbol(Twine(".") + Twine(SymName)));
+  };
----------------
jasonliu wrote:
> hubert.reinterpretcast wrote:
> > Should the name be adjusted to match that of the function introduced by https://reviews.llvm.org/D80402? @jasonliu?
> Yeah, I think matching them would be useful for grepping.
I do not think we can use MCSymbol *getFunctionEntryPointSymbol(const Function *F,const TargetMachine &TM) function ,  for the .memset or memcpy, we do not have Function object for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78929/new/

https://reviews.llvm.org/D78929





More information about the llvm-commits mailing list