[PATCH] D80868: [LiveDebugValues] Remove PendingInLocs (NFCI)

Mon Jun 1 08:33:57 PDT 2020

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

Hrrrmmmm. I think you're right -- IIRC, I originally added the "Pending" stuff, because I'd noticed that LiveDebugValues would need to delete locations as well as add them, to be correct (see rG0ae549814693eb2 <https://reviews.llvm.org/rG0ae549814693eb201d7e7a0a77856e55a98e19ee>), and the "Pending" flags got that done without affecting the rest of the pass. However, the main InLocs has since taken responsibility of that problem, so the Pending stuff is redundant. This patch would trip live-debug-values-remove-range.ll if that wasn't true. I built stage2 clang with rGdace8224f38a3 <https://reviews.llvm.org/rGdace8224f38a31636a02fe9c2af742222831f70c>, with and without this patch, and got identical binaries.

Please leave this ~24h in case there are more comments.

I've uploaded my view of what LiveDebugValues is doing in D80929 <https://reviews.llvm.org/D80929> in case that's helpful; I think it accurately summarises the discussion in D67500 <https://reviews.llvm.org/D67500>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80868/new/

https://reviews.llvm.org/D80868