[PATCH] D80920: AMDGPU: Fix alignment for dynamic allocas

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 08:33:56 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/non-entry-alloca.ll:98
 ; GCN-NEXT:    s_add_i32 s6, s32, 0x1000
-; GCN-NEXT:    s_andn2_b32 s6, s6, 63
+; GCN-NEXT:    s_and_b32 s6, s6, 0xfffff000
 ; GCN-NEXT:    s_lshl_b32 s7, s7, 2
----------------
madhur13490 wrote:
> Why is the opcode changed in assembly? you seemed to keep same DAG Opcode.
The inverted constant isn't an inline immediate so it wouldn't be beneficial to change it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80920/new/

https://reviews.llvm.org/D80920





More information about the llvm-commits mailing list