[PATCH] D78861: [Attributor] Track AA dependency using dependency graph

Luofan Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 08:33:53 PDT 2020


bbn added a comment.

In D78861#2066299 <https://reviews.llvm.org/D78861#2066299>, @kuter wrote:

> Hi, what is the state of this ?


Hi, I have just started my work on this.

> As of D78729 <https://reviews.llvm.org/D78729> a AbstractAttribute keeps track of its own dependencies.
> 
> It is possible to implement GraphTraits without using any extra memory by
>  directly implementing it on the Attributor and having the NodeRef as AbstractAttribute.
> 
> I suggest that we make AADepGraph a empty (for now) wrapper that takes in a Attributor reference and implement GraphTraits on it.

Thanks for the suggestion! This would make the graph lighter without any functionality loss, I will try to construct the graph in this way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78861/new/

https://reviews.llvm.org/D78861





More information about the llvm-commits mailing list