[PATCH] D78369: [DebugInfo] Reduce SalvageDebugInfo() functions

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 03:41:52 PDT 2020


Orlando added a comment.

LGTM. There are two other text only LGTMs on this patch and AFAICT the only blocker is the (inline) discussion on whether salvageDebugInfo needs renaming, but there doesn't seem to be a consensus. Does anyone have a strong opinion on this subject?

I feel like everyone agrees that the patch is good, but I don't want to press the button and to have inadvertently shut someone down.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78369/new/

https://reviews.llvm.org/D78369





More information about the llvm-commits mailing list