[PATCH] D80707: [legacyPM] Do not compute preserved analysis if there's no local change

Mon Jun 1 02:05:48 PDT 2020

foad added a comment.

In D80707#2065728 <https://reviews.llvm.org/D80707#2065728>, @serge-sans-paille wrote:

> > Perhaps if a pass returns false we should verify all analyses, rather than just the ones that the pass claims to preserve?
>
> That sounds like a good idea! Do you think that should be guarded by NDEBUG or by EXPENSIVE_CHECK?

I don't know! I would suggest making it NDEBUG for simplicity, unless it proves to be very expensive.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80707/new/

https://reviews.llvm.org/D80707