[PATCH] D80754: AMDGPU/GlobalISel: cmp/select method for insert element

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:278
+  unsigned NumElem = VecTy.getNumElements();
+  SmallVector<Register, 16> Ops;
+
----------------
Can initialize to the size here and avoid push_back


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:290
+
+  B.buildBuildVector(MI.getOperand(0).getReg(), Ops);
+  MI.eraseFromParent();
----------------
Don't need getReg here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80754/new/

https://reviews.llvm.org/D80754