[PATCH] D80497: Make mlir::Value's bool conversion operator explicit

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 31 10:06:15 PDT 2020


dblaikie added a comment.

In D80497#2065221 <https://reviews.llvm.org/D80497#2065221>, @mehdi_amini wrote:

> I believe that since we moved to the monorepo, the mailing-lists are added automatically based on the path touched in the reviews


Yeah, I think someone figured out how to make that happen, maybe even before the monorepo/a while back - and I stand by the position that I don't think it's appropriate to send mail to the mailing list for automated pre-commit testing. If it's not possible to use Phab in its current configuration to get the testing without sending email, please fix/improve phab to allow that before using it for non-reviewed pre-commit testing. I'll certainly keep an eye out for it & discourage the practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80497/new/

https://reviews.llvm.org/D80497





More information about the llvm-commits mailing list