[PATCH] D80862: [ObjectYAML][test] Address comments in D80203

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 30 18:02:07 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-str.yaml:18
 
-#                Name       Type     Address          Offset Size   ES Flg Lk Inf Al
+##               Name       Type     Address          Offset Size   ES Flg Lk Inf Al
 # SHDRS-DEFAULT: .debug_str PROGBITS 0000000000000000 000040 000006 01 MS  0  0   1
----------------
I think you can just make this a `SHDRS:` check line. The cost is negligible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80862/new/

https://reviews.llvm.org/D80862





More information about the llvm-commits mailing list