[PATCH] D80797: [DebugInfo] Check for errors when reading data for extended opcode

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 30 12:43:10 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:856
           FileNameEntry FileEntry;
-          const char *Name = TableData.getCStr(OffsetPtr);
+          const char *Name = TableData.getCStr(OffsetPtr, &Err);
           FileEntry.Name =
----------------
Does it help clarity using `DataExtractor::Cursor` and `StringRef getCStrRef(Cursor &C) const`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80797/new/

https://reviews.llvm.org/D80797





More information about the llvm-commits mailing list