[PATCH] D80868: [LiveDebugValues] Remove PendingInLocs (NFCI)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 30 07:56:00 PDT 2020


nikic created this revision.
nikic added reviewers: vsk, aprantl, jmorse, djtodoro.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

While trying to understand this code, I was confused about what the purpose of PendingInLocs is. As far as I can see, it ends up having the same result as InLocs, just computed in a more roundabout way. Am I missing something here?

With PendingInLocs gone, the computation of the Diff and Removed sets also seems unnecessary, and we can just compare if the old and the new set are the same.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80868

Files:
  lib/CodeGen/LiveDebugValues.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80868.267457.patch
Type: text/x-patch
Size: 5236 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200530/826c4711/attachment.bin>


More information about the llvm-commits mailing list