[PATCH] D80390: [WIP][mips] Support 64-bit relative relocations

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

It a relocation chain is indeed a perfect solution, this looks good to me!



================
Comment at: lld/test/ELF/mips-pc64.s:10
+# RUN:       }" > %t.script
+# RUN: ld.lld -shared %t.o -script %t.script -o %t.exe
+# RUN: llvm-objdump -s %t.exe | FileCheck %s
----------------
Probably avoid single dash `-script` which is uncommon. Use the double dash form.

Actually, I start to use `-T` which is much shorter.

The executable can just be `%t`.


================
Comment at: lld/test/ELF/mips-pc64.s:11
+# RUN: ld.lld -shared %t.o -script %t.script -o %t.exe
+# RUN: llvm-objdump -s %t.exe | FileCheck %s
+
----------------
`llvm-readelf -x .data` to be more specific about the tested section.


================
Comment at: lld/test/ELF/mips-pc64.s:21
+  .data
+  .global v0
+  .global v1
----------------
The labels can be dropped. They aren't used


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80390/new/

https://reviews.llvm.org/D80390