[PATCH] D75866: [AIX] supporting the visibility attribute for aix assembly

Fri May 29 13:41:19 PDT 2020

DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1609
+  default:
+    // TODO: Need to deal with other Linkages etc.
+    AsmPrinter::emitLinkage(GV, GVSym);
----------------
DiggerLin wrote:
> jasonliu wrote:
> > What is the extra linkage we need to deal here?
> > If we know the extra linkage we need to deal with and we don't want to deal with them now, then we have separate cases for those extra linkages and call `AsmPrinter::emitLinkage(GV, GVSym);`.
> > Ideally, I would want the default case to be `report_fatal_error` so that if we miss handling something, it would trigger.
> I added  AvailableExternallyLinkage .  I think we have deal with all the linkage with visibility. others we just pass to the AsmPrinter::emitLinkage(GV, GVSym) and let AsmPrinter::emitLinkage deal with it.
sorry, please discard above comment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75866/new/

https://reviews.llvm.org/D75866