[PATCH] D80778: [SelectionDAGBuilder][WebAssembly] Omit range checks on jump tables

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 10:53:47 PDT 2020


tlively planned changes to this revision.
tlively added a comment.

In D80778#2062416 <https://reviews.llvm.org/D80778#2062416>, @hans wrote:

> Before digging into the code, would it be impractical to fold the range check into the br_table instruction in the wasm backend instead, "sniffing out the guard" and replacing it as suggested by that comment in WebAssemblyISelLowering.cpp?
>
> Because I'm a little bit worried about this ipushing complexity up to the general switch lowering mechanism, for example breaking the invariant that jump tables have a size that matches their corresponding case range.


That's a fair concern. I'll try that approach and report back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80778/new/

https://reviews.llvm.org/D80778





More information about the llvm-commits mailing list