[PATCH] D79959: [SampleFDO] Add use-sample-profile function attribute

[Wei Mi via Phabricator via llvm-commits]

wmi marked 4 inline comments as done.
wmi added inline comments.


================
Comment at: clang/test/CodeGen/use-sample-profile-attr.c:4
+//
+// RUN: %clang_cc1 -O2 -fno-experimental-new-pass-manager
+// -fprofile-sample-use=%S/Inputs/pgo-sample.prof %s -emit-llvm -o - 2>&1 |
----------------
MaskRay wrote:
> You need one `RUN:` for each continuation line.
clang-format changed it to multiple lines. Thanks for catching it. Fixed.


================
Comment at: llvm/test/Transforms/Inline/inline-incompat-attrs.ll:23
+define i32 @caller1(i32 %y1) {
+; caller1 doesn't have use-sample-profile attribute but callee2 has,
+; so callee2 won't be inlined into caller1.
----------------
MaskRay wrote:
> You may consider `;; ` for comments, which can make comments stand out from RUN/CHECK lines.
> 
> Perhaps you have an opinion on D79276? :)
Changed.


================
Comment at: llvm/test/Transforms/SampleProfile/use-sample-profile-attr.ll:118
+!27 = !DILocation(line: 11, column: 20, scope: !7)
+
----------------
MaskRay wrote:
> trailing empty line
Fixed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79959/new/

https://reviews.llvm.org/D79959