[PATCH] D80611: [BrachProbablityInfo] Proportional distribution of reachable probabilities

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi accepted this revision.
yamauchi added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:385
+  BranchProbability NewUnreachableSum = BranchProbability::getZero();
+  for (auto i : UnreachableIdxs)
+    NewUnreachableSum += BP[i];
----------------
yrouban wrote:
> yamauchi wrote:
> > Capitalize 'i' -> 'I'.
> > 
> > This loop could be combined with the above loop, but would be less clear?
> The old code above has the index //i// lowcased. I would propose to keep the style.
> Yes, the separate loop is for clarity.
> 
OK, though in general I'd encourage to update to the capitalized variable name style in newly added code. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80611/new/

https://reviews.llvm.org/D80611