[PATCH] D80803: [DebugInfo] Add flush to ensure debug line errors are in right place

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In D80803#2063224 <https://reviews.llvm.org/D80803#2063224>, @dblaikie wrote:

> Not sure I feel great about having these things synchronized - seems likely there's lots of error messages that get interspersed with stdout in llvm-dwarfdump and we aren't likely to get all the stdout flushed appropriately, so maybe we shouldn't start/try? If the test is flakey/unreliable due to this - perhaps it should FileCheck stdout and stderr separately rather than piping them together?


+1. Given that the WarningHandler is configurable I don't think we should be making assumptions of what it's doing, even if printing stderr is the default. I would even go a step further and remove the existing flushes so the test don't rely on them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80803/new/

https://reviews.llvm.org/D80803