[PATCH] D78865: [DWARF5] Replace emission of strp with stx forms in debug_macro section

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds good to me - thanks!

> One more big win in non-DWO case is that switching to strx form will save a relocation per macro entry compared to the counter part strp form which uses relocation.

Unfortunately I don't think it will provide this benefit - since the str_offsets section will require a relocation for the string anyway. (& though if a macro string is used more than once (probably relatively rare, but not unheard of - def/undef around .def files more than once in the same .cpp file, etc) then strx will at least allow that string to only need one relocation rather than one per use)

But I think the greater benefit of consistency is worthwhile in any case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78865/new/

https://reviews.llvm.org/D78865