[PATCH] D78669: PowerPC: Add emergency stack spill slots for SPE

[Justin Hibbits via Phabricator via llvm-commits]

jhibbits marked 3 inline comments as done.
jhibbits added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:2043
 
   // The scavenger might be invoked if the frame offset does not fit into
   // the 16-bit immediate. We don't know the complete frame size here
----------------
sfertile wrote:
> Should probably extend this sentence to include `(or 8-bit immediate for powerpcspe)`.
Good point, will do.


================
Comment at: llvm/test/CodeGen/PowerPC/spe-spills.ll:7
+
+ at d = local_unnamed_addr global double* null, align 4
+ at c = local_unnamed_addr global i32 0, align 4
----------------
sfertile wrote:
> Is it possible to handwrite a simple test to expose the issue? If its too difficult we can stick with this test but I think something simpler which showcases the problem would be ideal.
I'll see if I can reduce it to something simple.  This is actually the post-creduce result that exhibited the issue, any more reduction and it doesn't seem to trip it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78669/new/

https://reviews.llvm.org/D78669