[PATCH] D80797: [DebugInfo] Check for errors when reading data for extended opcode

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 07:01:55 PDT 2020


jhenderson created this revision.
jhenderson added reviewers: JDevlieghere, dblaikie, probinson, aprantl, ikudrin, MaskRay.
Herald added subscribers: cmtice, hiraditya.
Herald added a project: LLVM.
jhenderson edited the summary of this revision.
jhenderson added a parent revision: D80796: [DebugInfo] Add use of truncating data extractor to debug line parsing.
jhenderson added a subscriber: labath.

Previously, if an extended opcode was truncated, it would manifest as an "unexpected line op length error" which wasn't quite accurate. This change checks for errors any time data is read whilst parsing an extended opcode, and reports any errors detected.

Depends on D80796 <https://reviews.llvm.org/D80796>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80797

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDataExtractor.h
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80797.267221.patch
Type: text/x-patch
Size: 5651 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200529/6648419f/attachment.bin>


More information about the llvm-commits mailing list