[PATCH] D80785: [MLIR][BUFFER_PLACEMENT] Introduce CallOp converter for buffer placement

[Alexander Belyaev via Phabricator via llvm-commits]

pifon2a added inline comments.


================
Comment at: mlir/lib/Transforms/BufferPlacement.cpp:508
+
+      // No replaces are required.
+      replacingValues.push_back(nullptr);
----------------
nit: `No replacing is required.`


================
Comment at: mlir/test/Transforms/buffer-placement-preparation.mlir:214
+func @callee(%arg1: tensor<5xf32>) -> tensor<5xf32> {
+  %0 = linalg.generic {args_in = 1 : i64, args_out = 1 : i64, indexing_maps = [#map0, #map0], iterator_types = ["parallel"]} %arg1 {
+  ^bb0(%gen1_arg0: f32):
----------------
Please, format IR to fit 80 chars, smth like:
  %0 = linalg.generic {
         args_in = 1 : i64, 
         args_out = 1 : i64,
         indexing_maps = [#map0, #map0], 
         iterator_types = ["parallel"]
       } %arg1 {



================
Comment at: mlir/test/Transforms/buffer-placement-preparation.mlir:257
+
+// CHECK-LABEL: func @callee
+func @callee(%arg1: tensor<5xf32>) -> (tensor<5xf32>, memref<2xf32>) {
----------------
that's nice that we can already do that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80785/new/

https://reviews.llvm.org/D80785