[PATCH] D79835: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 29 02:41:03 PDT 2020


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:1037
 bool InstrProfiling::emitRuntimeHook() {
   // We expect the linker to be invoked with -u<hook_var> flag for linux,
   // for which case there is no need to emit the user function.
----------------
Nit: s/for linux/for Linux or Fuchsia/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79835/new/

https://reviews.llvm.org/D79835





More information about the llvm-commits mailing list