[PATCH] D80364: [amdgpu] Teach load widening to handle non-DWORD aligned loads.

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 20:19:31 PDT 2020


hliao added a comment.

In D80364#2061467 <https://reviews.llvm.org/D80364#2061467>, @arsenm wrote:

> In D80364#2061379 <https://reviews.llvm.org/D80364#2061379>, @hliao wrote:
>
> > Remove an inpractical test.
>
>
> I mean beyond the test, I think the whole patch is unnecessary now. Do you have an example of real source that still needs this?


`test2`, that's a real example. The widening done in this patch is not supported in any code in LLVM. The load itself is not DWORD aligned but only naturally aligned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80364/new/

https://reviews.llvm.org/D80364





More information about the llvm-commits mailing list