[PATCH] D80772: [mlir] [VectorOps] Use 'vector.flat_transpose' for 2-D 'vector.tranpose'

[Aart Bik via Phabricator via llvm-commits]

aartbik marked an inline comment as done.
aartbik added inline comments.


================
Comment at: mlir/test/Dialect/Vector/vector-flat-transforms.mlir:5
+//
+// TODO(ajcbik,ntv): having ShapeCastOp2DDownCastRewritePattern and
+//                   ShapeCastOp2DUpCastRewritePattern too early in
----------------
sending this out for some early discussion; this hits a phase ordering issue

I propose to move the shapecast lowering a bit later, so we can fold them first and only lower them when they cannot be eliminated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80772/new/

https://reviews.llvm.org/D80772