[PATCH] D79508: [mlir][gpu] Refactor functions for workgroup and private buffer attributions.

[Wen-Heng (Jack) Chung via Phabricator via llvm-commits]

whchung marked 3 inline comments as done.
whchung added inline comments.


================
Comment at: mlir/include/mlir/Dialect/GPU/GPUOps.td:203
+    unsigned getNumPrivateAttributions() {
+      return getOperation()->getNumOperands() - getType().getNumInputs() -
+          getNumWorkgroupAttributions();
----------------
whchung wrote:
> rriddle wrote:
> > This doesn't make sense to me, when does GPUFuncOp ever have operands? Did you mean to use numArguments here? This looks like a lack of testing coverage if so.
> Thanks for catching this. Indeed this is a bug not covered by any existing tests. I'll submit another patch addressing this with a test.
@rriddle I submitted D80766 to fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79508/new/

https://reviews.llvm.org/D79508