[PATCH] D80662: [LiveDebugValues] Add cutoffs to avoid pathological behavior

[Vedant Kumar via Phabricator via llvm-commits]

vsk marked an inline comment as done.
vsk added a comment.

Thanks for the reviews!



================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1769
+
+  if (RPONumber > InputBBLimit) {
+    unsigned NumInputDbgValues = 0;
----------------
jmorse wrote:
> Iterating over all instructions again is probably unfortunate for performance -- it could be counted on line 1744 of this patch?
> 
> On the other hand, given the exceptional circumstances that this will trigger in, that's not really a concern.
It seems a bit cleaner to separate the concerns. For inputs where the extra scan would be a performance issue, the pass is likely to bail out anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80662/new/

https://reviews.llvm.org/D80662