[PATCH] D80665: [MachineLICM] Assert that locations from debug insts are not lost

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 13:45:50 PDT 2020


vsk added a comment.

In D80665#2060766 <https://reviews.llvm.org/D80665#2060766>, @jmorse wrote:

> LGTM -- I'd suggest that the assertion messages could become something like "Shouldn't be hoisting debug instructions" or similar. IMO, as well as the matter of dropping DebugLocs, debug instructions should (almost?) never appears as a candidate to be moved around like another instruction.


Thanks, I'll fix this before committing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80665/new/

https://reviews.llvm.org/D80665





More information about the llvm-commits mailing list