[PATCH] D79864: [PowerPC] Add new linker optimization for PowerPC

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 12:38:46 PDT 2020


efriedma added a comment.

And now I somehow submitted before I was done writing my comment.  Trying again.

---

Just looked at what I wrote, and the issue I'm seeing isn't clear.

The code doesn't require that the pld and the lwa are adjacent.  Therefore, it's possible that some instruction between the pld and the lwa writes to the destination register of the lwa.  If there is such an instruction, the linker optimization would cause a miscompile: the loaded value would be clobbered.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79864/new/

https://reviews.llvm.org/D79864





More information about the llvm-commits mailing list