[PATCH] D80406: [LLD][ThinLTO] A switch to allow compilation of only one module.

Thu May 28 10:56:21 PDT 2020

tejohnson added a comment.

In D80406#2060623 <https://reviews.llvm.org/D80406#2060623>, @hoyFB wrote:

> In D80406#2060565 <https://reviews.llvm.org/D80406#2060565>, @tejohnson wrote:
>
> > In D80406#2057639 <https://reviews.llvm.org/D80406#2057639>, @tejohnson wrote:
> >
> > > Can you beef up the testing? I.e. ensure that the save temps output files for just the specified module get created. Also please add a test to make sure this interacts well with distributed thinlto build options, i.e. -thinlto-index-only (e.g. that it creates the expected output files just for the specified module).
> >
> >
> > Not sure if you saw this comment from my earlier reply - please add additional testing as suggested above.
>
>
> It's added. E.g, the `not ls single1.o2` line checks only two intermediate objects are generated, one is the dummy `ld-temp.o` and the other has the symbol specified in the command line. The `IDX` checks are for thinlto index testing. Do you want me to add more? Thanks.

Oh I see now that a -thinlto-index-only invocation was added. What you should be testing for is the output file specific to the specified object. E.g. typically there is a *.thinlto.bc file emitted for each input object. We should get only the one corresponding to the specified module in this case.

Also the other test suggestion I had was to make sure that the save-temps output files work as expected (still get the ones corresponding to the specified module, and not for the other modules). There are a number of .bc files emitted for each object with save-temps but it would be fine to check for one of them I think.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80406/new/

https://reviews.llvm.org/D80406