[PATCH] D79546: [VE] Implements minimum MC layer for VE (4/4)

[Kazushi Marukawa via Phabricator via llvm-commits]

kaz7 planned changes to this revision.
kaz7 marked an inline comment as done.
kaz7 added a comment.

Thanks for reviewing.  Yes, you are correct.  I removed relocation features too from this patch.  I added comments in the commit message.  Thanks.



================
Comment at: llvm/lib/Target/VE/AsmParser/VEAsmParser.cpp:622
+  switch (getLexer().getKind()) {
+  case AsmToken::LParen:
+    // FIXME: Parsing "(" + %vreg + ", " + %vreg + ")"
----------------
simoll wrote:
> I suppose there should be a TODO here for the `(m)1` and `(m)0` immediates?
Thank you for taking a look.  The answer is no.  This todo is for a special operand of `vsld` and `vsrd` instructions.  These instructions are something like `vsld %vx, (%vy, %vz), %sy, %vm`.  I had not noticed this special operand until I try to run my regression tests through NEC assembler.  On the other hand, `(m)1` and `(m)0` immediate values will be implemented using individual `parseMImmOperand` function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79546/new/

https://reviews.llvm.org/D79546