[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

Balogh, Ádám via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 06:31:49 PDT 2020


baloghadamsoftware marked 5 inline comments as done.
baloghadamsoftware added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:917
     assert(isa<GlobalsSpaceRegion>(sReg) || isa<StackSpaceRegion>(sReg) ||
            isa<BlockDataRegion>(sReg) || isa<UnknownSpaceRegion>(sReg));
   }
----------------
balazske wrote:
> This assert should not be duplicated. It has the place in `VarRegion` or `NonParamVarRegion`, but not both.
Copy-paste...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80522/new/

https://reviews.llvm.org/D80522





More information about the llvm-commits mailing list