[PATCH] D80596: New intrinsc @llvm.get.active.lane.mask()

[Simon Moll via Phabricator via llvm-commits]

simoll added inline comments.


================
Comment at: llvm/docs/LangRef.rst:16416
+where ``%m`` is the mask of active/inactive lanes with its elements indexed by
+``i``, ``%base`` is the first element of the vector induction variable (VIV),
+and ``%n`` is the back-edge taken count, except when the VIV overflows, in
----------------
You don't need the VIV and back-edge taken count here to describe the semantics of the intrinsic. It makes sense to mention them only in the second paragrah referring to vector hwloops. So, the first paragraph would  be about the semantics and the second paragraph below would explain how this is used for hwloops.


================
Comment at: llvm/docs/LangRef.rst:16418
+and ``%n`` is the back-edge taken count, except when the VIV overflows, in
+which case they return false in the lanes where the VIV overflows. And this is
+equivalent to:
----------------
To make it clear that overflows cannot occur, you could instead say that the implied `%base + i` and comparison against `%n` is performed properly in the integer numbers (and not machine integers).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80596/new/

https://reviews.llvm.org/D80596