[PATCH] D80706: [DAGCombine] Add hook to allow target specific test for sqrt input

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 04:51:15 PDT 2020


nemanjai added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:21382
+            // Test = X == 0.0
+            Test = DAG.getSetCC(DL, CCVT, Op, FPZero, ISD::SETEQ);
         }
----------------
steven.zhang wrote:
> Question here: do we miss to propagate the SDFlags for SETCC which might affect how we lower the select_cc ?
This thread may be relevant here: http://lists.llvm.org/pipermail/llvm-dev/2020-May/141561.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80706/new/

https://reviews.llvm.org/D80706





More information about the llvm-commits mailing list