[PATCH] D79863: [DebugInfo] Refactor SalvageDebugInfo and SalvageDebugInfoForDbgValues

Chris Jackson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 03:45:28 PDT 2020


chrisjackson added a comment.

Are there any more suggestions please?



================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1659
+  }
+  return salvaged;
 }
----------------
Orlando wrote:
> nit: I think this would be clearer, but not a strong opinion at all.
> ```
> if (salvaged)
>    return true;
> 
> // <undef-code>
> return false;
> ```
Yes I prefer this too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79863/new/

https://reviews.llvm.org/D79863





More information about the llvm-commits mailing list