[PATCH] D80497: Make mlir::Value's bool conversion operator explicit

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 03:13:02 PDT 2020


mehdi_amini added a comment.

In D80497#2059323 <https://reviews.llvm.org/D80497#2059323>, @mehdi_amini wrote:

> In D80497#2055817 <https://reviews.llvm.org/D80497#2055817>, @dblaikie wrote:
>
> > @mehdi_amini - would you mind writing some kind of comment when you approve a patch in Phabricator? Without any text in the approval, the email is not sent to the mailing list (only to the people in the review) & it looks like the patch is then committed without approval (according to the mail on the mailing list).
>
>
> I don't think I can promise to remember this, this is too easy to forget to me.


(of course I'll try, that was a disclaimer because I know myself and I'm not good at manual processes: I've been doing OK with computers because I can automate stuff)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80497/new/

https://reviews.llvm.org/D80497





More information about the llvm-commits mailing list