[PATCH] D80542: [DAGCombiner] Require ninf for division estimation

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 02:08:07 PDT 2020


qiucf added a comment.

> @steven.zhang : We might have to add some test before doing the software expansion as what we did for sqrt. But this check may hurt the performance.

Yes.. On PowerPC, we have a '//test//' instruction to determine whether two numbers are suitable for division estimation or not. (extremely big/small numbers, `x` is nan/inf, `y` is nan/inf/zero...) And I think we don't need this flag requirement after such exploitation. (maybe move the check inside `BuildDivEstimate` and add a hook?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80542/new/

https://reviews.llvm.org/D80542





More information about the llvm-commits mailing list