[PATCH] D79516: merge-request.sh: Rewrite to use git

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 01:35:13 PDT 2020


hans accepted this revision.
hans edited reviewers, added: hans; removed: hansw.
hans added a comment.

Sorry, I completely missed this. lgtm



================
Comment at: llvm/utils/release/merge-request.sh:161
+for r in $revisions; do
+  short_rev_string="$short_rev_string `echo $r | cut -c 1-7`"
 done
----------------
That's a nice improvement.

I'm not sure 7 characters is long enough to be a unique hash though.

Running this:

```
$ git rev-list --all --abbrev=0 --abbrev-commit |   awk '{ a[length] += 1 } END { for (len in a) print len, a[len] }'
5 8568
6 276655
7 69935
8 4939
9 294
10 21
```

suggests we have some commits that require 10 chararacters for the short hash to be unique. So maybe we should use 10? Hopefully that will last a while.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79516/new/

https://reviews.llvm.org/D79516





More information about the llvm-commits mailing list