[PATCH] D80684: [LiveDebugValues] Speed up removeEntryValue, NFC

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 28 01:35:11 PDT 2020


djtodoro added a comment.

Great!



================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:917
       const VarLoc &VL = VarLocIDs[LocIndex::fromRawInteger(ID)];
-      if (!VL.isEntryBackupLoc())
-        continue;
----------------
I'm not sure we want to remove this line. The backup locations are `EntryValueBackupKind` and `EntryValueCopyBackupKind` only; the `EntryValueKind` is real location created from one of these two.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80684/new/

https://reviews.llvm.org/D80684





More information about the llvm-commits mailing list