[PATCH] D80610: [llvm-exegesis] Make createCounter a virtual method on Target to allow targets to create target-specific counters

[Clement Courbet via Phabricator via llvm-commits]

courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.

LGTM modulo one comment.



================
Comment at: llvm/tools/llvm-exegesis/lib/PerfHelper.h:85
+  /// Returns the current value of the counter or -1 if it cannot be read.
+  virtual int64_t read() const;
 
----------------
I don't think this needs to be virtual, does it ? `readOrError` is the real thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80610/new/

https://reviews.llvm.org/D80610